[RLlib] Add config option to enable/disable TO vs FROM worker filter updates (aka filter syncing). #36204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rllib/algorithms/algorithm_config.py
Outdated
| @@ -1470,6 +1468,14 @@ def rollouts( | |||
| enable_connectors: Use connector based environment runner, so that all | |||
| preprocessing of obs and postprocessing of actions are done in agent | |||
| and action connectors. | |||
| use_worker_filter_stats: Whether to use the workers in the WorkerSet to | |||
| update the central filters (held by the local worker). If False, stats | |||
| from the workers will not be used ad discarded. | |||
rllib/utils/filter_manager.py
Outdated
| for k in local_filters: | ||
| local_filters[k].apply_changes(rf[k], with_buffer=False) | ||
|
|
||
| # Should we update the remote workers' filters from the (now synched) |
There was a problem hiding this comment.
"now possibly synched?"
ArturNiederfahrenhorst
approved these changes
Jun 9, 2023
|
Thanks for your review @ArturNiederfahrenhorst ! :) Will fix the issues and then merge. |
…config_option_to_not_include_eval_data_in_filter_stats
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…updates (aka filter syncing). (ray-project#36204) Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config option to enable/disable TO vs FROM worker filter updates (aka filter syncing):
config.synchronize_filter) to NOT update a WorkerSet's remote worker filters from the central filters (held by the local workers).This PR introduces the missing setting (
config.use_worker_filter_stats) and clarifies the difference between these two options by better config property naming. The old setting name (config.synchronize_filter) has been soft-deprecated and replaced byconfig.update_worker_filter_stats.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.