Remove extra step in M1 installation instructions #36029
Conversation
There was a problem hiding this comment.
I was able to successfully install in a new conda environment on my laptop, but it may be helpful to verify through a completely fresh M1 (VM?) to confirm if it just works.
There was a problem hiding this comment.
I tried this out on a fresh M1 now :)
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
| @@ -272,7 +272,7 @@ You can install and use Ray C++ API as follows. | |||
| M1 Mac (Apple Silicon) Support | |||
| ------------------------------ | |||
|
|
|||
| Ray has experimental support for machines running Apple Silicon (such as M1 macs). | |||
| Ray supports machines running Apple Silicon (such as M1 macs). | |||
| Multi-node clusters are untested. To get started with local Ray development: | |||
|
|
|||
| #. Install `miniforge <https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh>`_. | |||
There was a problem hiding this comment.
Actually do you know if these miniforge instructions are still needed? Was this primarily for installing grpcio?
There was a problem hiding this comment.
It is just a convenient way to get things up and running, that's why I kept it. When I was trying stuff out, these instructions helped to get a good Python distribution installed, that's why I put it back. But no strong opinions here :)
There was a problem hiding this comment.
Ah I see. Reading over this section again now, I feel that there shouldn't be any more unique differences from the other operating systems which are covered by the Official Releases section.
Any thoughts on recommending using conda across different operating systems, rather than just for M1?
There was a problem hiding this comment.
In general, we probably shouldn't be in the business of recommending Python distributions to people. On M1 there is a little more ambiguity since e.g. you could use an x86 distribution and Rosetta (which grpc actually recommended for a while) and some of the non-conda distributions might be less well supported.
I'll merge the PR now because it strictly improves things, but happy to remove this section altogether in a follow up PR :)
After ray-project#35932, nothing special is needed any more on M1. --------- Signed-off-by: Philipp Moritz <pcmoritz@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
After #35932, nothing special is needed any more on M1.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.