New plasma client api #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e54af93 to
b97df6d
Compare
…en calling plasma_fetch_remote() twice. See XXX comment in client_tests.c
…or the same object.
pcmoritz
reviewed
Nov 23, 2016
| object_req->timer = event_loop_add_timer(client_conn->manager_state->loop, | ||
| MANAGER_TIMEOUT, | ||
| fetch_timeout_handler, | ||
| object_req); | ||
| request_transfer_from(client_conn, object_id); | ||
| /* let scheduling the fetch request proceded and return */ | ||
| } |
There was a problem hiding this comment.
the PLASMA_OBJECT_REMOTE message after this line should only be sent if manager_count is not zero
…tification to work with both path codes
…. However the tests for plasma_wait_for_objects() are not complete as they require the new subscribe()
|
Replaced by #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.