[Ray Core] Issue#35880 Fix the Exception error message bug which convert byte array to String #35883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fantow <1727611626@qq.com>
jovany-wang
reviewed
May 31, 2023
| @@ -49,7 +48,7 @@ public static List<FunctionArg> wrap(Object[] args, Language language) { | |||
| throw new IllegalArgumentException( | |||
| String.format( | |||
| "Can't transfer %s data to %s", | |||
| Arrays.toString(value.metadata), language.getValueDescriptor().getName())); | |||
| new String(value.metadata), language.getValueDescriptor().getName())); | |||
There was a problem hiding this comment.
I don't think we can just pack it in string type as we use raw bytes instead of string in Python: https://github.com/ray-project/ray/blob/master/python/ray/_private/ray_constants.py#L299-L303
One possible solution is that we align these stuff in both Java and Python, for example,
if (meta == b'PYTHON') {
new String("PYTHON");
} ...
jovany-wang
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Discussed with @fantow offline, the value.metadata is only generated in current Java process, without any potential risk in cross language.
|
CI failed. |
|
Lintcheck failure is unrelated. Retrying other failed CI jobs. |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…o String. (ray-project#35883) Signed-off-by: fantow <1727611626@qq.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I just get a strange exception message when I call the Ray.task() with a non-basic class type.
It seems like a wrong convert from byte[] to String with Arrays.toString().