Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Cancel pg.ready() task for pending trials that end up reusing an actor #35748

Merged
merged 3 commits into from
May 25, 2023
+4 −0
Merged

[Tune] Cancel pg.ready() task for pending trials that end up reusing an actor #35748

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
868dc71
ray.cancel on the pg.ready() task of a cancelled resource request
justinvyu May 11, 2023
0b8347c
fix comment
justinvyu May 24, 2023
abad1cd
Merge branch 'master' of https://github.com/ray-project/ray into tune…
justinvyu May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
justinvyu committed May 24, 2023
commit 0b8347c6a17107af3edf5149977e027c5b481cfa
4 changes: 2 additions & 2 deletions python/ray/air/execution/resources/placement_group.py
View file
Original file line number Diff line number Diff line change
@@ -152,8 +152,8 @@ def cancel_resource_request(self, resource_request: ResourceRequest):
future = self._pg_to_staging_future.pop(pg)
self._staging_future_to_pg.pop(future)

# Cancel the pg.ready task. Otherwise, it will be pending node
# assignment forever and accumulate throughout the job lifetime.
# Cancel the pg.ready task.
# Otherwise, it will be pending node assignment forever.
ray.cancel(future)
else:
# PG might be ready