Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fix link to Try it out #34924

Merged
merged 1 commit into from
May 1, 2023
Merged

[docs] fix link to Try it out #34924

merged 1 commit into from
May 1, 2023

Conversation

simran-2797
Copy link
Contributor

replaced the Ray core collab example with Ray AIR

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simran-2797
New Ray AIR link for try it out
6a36d23 
replaced the Ray core collab example with Ray AIR

Signed-off-by: Simran Mhatre <simran@anyscale.com>
@simran-2797 simran-2797 requested a review from a team as a code owner May 1, 2023 20:19
angelinalg
angelinalg approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelinalg angelinalg mentioned this pull request May 1, 2023
Closed
@angelinalg angelinalg changed the title [docs] Landing page changes [docs] fix link to Try it Now May 1, 2023
@jjyao jjyao merged commit 7071a4f into master May 1, 2023
@jjyao jjyao deleted the simran-2797-patch-1 branch May 1, 2023 22:00
@angelinalg angelinalg changed the title [docs] fix link to Try it Now [docs] fix link to Try it out May 1, 2023
angelinalg pushed a commit to angelinalg/ray that referenced this pull request May 2, 2023
@simran-2797 @angelinalg
[docs] New Ray AIR link for try it out (ray-project#34924)
b9eb923 
replaced the Ray core collab example with Ray AIR

Signed-off-by: Simran Mhatre <simran@anyscale.com>
@angelinalg angelinalg mentioned this pull request May 2, 2023
Merged
8 tasks
jjyao pushed a commit that referenced this pull request May 3, 2023
@angelinalg @simran-2797
[docs] Cherrypick fixes to links (#34975)
19d949c 
#34720, #34924

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Simran Mhatre <simran@anyscale.com>
Co-authored-by: Simran Mhatre <simran@anyscale.com>
@angelinalg angelinalg mentioned this pull request May 5, 2023
Merged
8 tasks
angelinalg added a commit to angelinalg/ray that referenced this pull request May 6, 2023
@angelinalg
Revert "[docs] New Ray AIR link for try it out (ray-project#34924)"
85b0e75 
Already merged with ray-project#34975 (which included #334720 and ray-project#34924)
This reverts commit b9eb923.
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@simran-2797 @architkulkarni
[docs] New Ray AIR link for try it out (ray-project#34924)
bafce59 
replaced the Ray core collab example with Ray AIR

Signed-off-by: Simran Mhatre <simran@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simran-2797 @angelinalg @jjyao