[tune] Release test for durable multifile checkpoints #34860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
8 tasks
added 2 commits
April 28, 2023 12:58
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
justinvyu
approved these changes
Apr 30, 2023
Comment on lines
-145
to
-148
| class AwsDurableTrainable(TestDurableTrainable): | ||
| AWS_ACCESS_KEY_ID = aws_key_id | ||
| AWS_SECRET_ACCESS_KEY = aws_secret | ||
| AWS_SESSION_TOKEN = aws_session |
There was a problem hiding this comment.
This stuff is not needed anymore due to propagating the env vars in the runtime env from the previous PR?
There was a problem hiding this comment.
That's one thing - the other is that the cluster infrastructure now correctly sets up credentials on all worker nodes
release/tune_tests/scalability_tests/workloads/test_durable_multifile_checkpoints.py
Outdated
Show resolved
Hide resolved
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
) We are currently only testing single-file checkpoints. However, there have been performance regressions with multi-file checkpoints due to unthreaded uploads in pyarrow. These have since been resolved, but we should collect metrics to catch future regressions. When comparing against a [version where the improvements have been reverted](ray-project#34861), we observe significant improvements in runtime: ``` 2023-04-28 06:52:38,151 INFO tune.py:1011 -- Total run time: 362.95 seconds (337.86 seconds for the tuning loop). ``` vs. ``` 2023-04-28 06:54:57,166 INFO tune.py:1011 -- Total run time: 472.55 seconds (436.54 seconds for the tuning loop). ``` Signed-off-by: Kai Fricke <kai@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We are currently only testing single-file checkpoints. However, there have been performance regressions with multi-file checkpoints due to unthreaded uploads in pyarrow. These have since been resolved, but we should collect metrics to catch future regressions.
When comparing against a version where the improvements have been reverted, we observe significant improvements in runtime:
vs.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.