[Train] Fix lightning trainer devices setting #34419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
matthewdeng
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
BTW the functionality was actually changed in this PR: #32893
| @@ -21,12 +21,21 @@ | |||
| LIGHTNING_REPORT_STAGE_KEY = "_report_on" | |||
|
|
|||
|
|
|||
| def _get_worker_root_device(): | |||
There was a problem hiding this comment.
nit: Does this need to be underscore prefixed?
There was a problem hiding this comment.
Oh I was trying to indicate that this function is used internally. But since we didn't expose it to the users, and internal functions in other similar modules don't have a leading underscore, I'm also going to remove it.
There was a problem hiding this comment.
Yeah I also saw this file itself has a leading underscore, so I'm assuming everything in it is supposed to be internal?
There was a problem hiding this comment.
Yeah I think so:) I've updated the code.
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
…ng_trainer_get_devices
…ng_trainer_get_devices
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previously,
ray.train.torch.get_devices()only returns one torch.device. PR [#32893] changed the logic ofget_devices(), which returns a list of torch.device objects if there are multiple GPUs in a worker.This PR aims to adapt to this change.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.