Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requirements] Add PyArrow to ray[tune] dependencies #34397

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Ray Tune depends on PyArrow for filesyncing. However, ray[tune] currently does not include pyarrow as a dependency, which means version constraints are not enforced and syncing is not guaranteed to work out of the box.

This surfaced as a problem when a user used poetry with ray[tune] as a constraint, but an incompatible version of pyarrow was installed. In this case, syncing to cloud storage was broken.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 2 commits April 14, 2023 15:18
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 14, 2023
@krfricke krfricke merged commit de1b16f into ray-project:master Apr 17, 2023
@krfricke krfricke deleted the requirements/tune-pyarrow branch April 17, 2023 08:34
vitsai pushed a commit to vitsai/ray that referenced this pull request Apr 17, 2023
Ray Tune depends on PyArrow for filesyncing. However, `ray[tune]` currently does not include pyarrow as a dependency, which means version constraints are not enforced and syncing is not guaranteed to work out of the box.

This surfaced as a problem when a user used poetry with `ray[tune]` as a constraint, but an incompatible version of pyarrow was installed. In this case, syncing to cloud storage was broken.

Signed-off-by: Kai Fricke <kai@anyscale.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
Ray Tune depends on PyArrow for filesyncing. However, `ray[tune]` currently does not include pyarrow as a dependency, which means version constraints are not enforced and syncing is not guaranteed to work out of the box.

This surfaced as a problem when a user used poetry with `ray[tune]` as a constraint, but an incompatible version of pyarrow was installed. In this case, syncing to cloud storage was broken.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Ray Tune depends on PyArrow for filesyncing. However, `ray[tune]` currently does not include pyarrow as a dependency, which means version constraints are not enforced and syncing is not guaranteed to work out of the box.

This surfaced as a problem when a user used poetry with `ray[tune]` as a constraint, but an incompatible version of pyarrow was installed. In this case, syncing to cloud storage was broken.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants