Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][oom] cherry pick "Use retriable lifo policy for dask 3x nightly test " #32425

Merged
merged 1 commit into from
Feb 10, 2023
Merged

[core][oom] cherry pick "Use retriable lifo policy for dask 3x nightly test " #32425

merged 1 commit into from
Feb 10, 2023

Conversation

clarng
Copy link
Contributor

@clarng clarng commented Feb 10, 2023

Why are these changes needed?

Cherry pick #32361 to resolve release test failure of "dask_on_ray_1tb_sort" in 3x nightly

Related issue number

#32195

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarng clarng changed the base branch from master to releases/2.3.0 February 10, 2023 18:07
@clarng clarng requested a review from cadedaniel February 10, 2023 18:07
@clarng clarng marked this pull request as ready for review February 10, 2023 18:07
@clarng
[core][oom] Use retriable lifo policy for dask 3x nightly test (#32361)
7c77e91 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>

3x nightly dask test is failing, due to enabling of group-by-owner oom killer policy

This switches the test to use the previous policy

Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
cadedaniel
cadedaniel approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clarng!! cc @zhe-thoughts

zhe-thoughts
zhe-thoughts approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for cherry picking into 2.3.0!

@cadedaniel cadedaniel merged commit 7c6ecce into releases/2.3.0 Feb 10, 2023
@cadedaniel cadedaniel deleted the dask branch February 10, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadedaniel cadedaniel cadedaniel approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

Assignees

@cadedaniel cadedaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarng @cadedaniel @zhe-thoughts