[dashbaord] Increase gcs health check failure threshold. #31939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yi Cheng 74173148+iycheng@users.noreply.github.com
Why are these changes needed?
When GCS is overloaded, health check in dashboard will fail esily and thus dashboard will exit. Right now, there is no way to restart the dashboard in the user side, so exit the dashboard means the cluster will lose all the functions implemented there, like status api/logs/jobs/...
To mitigate this, the threshold is increased, and thus the maximum time is 10min.
A better solution is needed to take care of the dashboard failure.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.