Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler] Add env RAY_ENABLE_CLUSTER_STATUS_LOG to disable periodic cluster status log. #31869

Conversation

DmitriGekhtman
Copy link
Contributor

Why are these changes needed?

This PR adds an env flag to disable periodic autoscaler cluster status logging.

Users may wish to disable these logs because:

  • The log entry is rather long and communicates cluster status rather than events in the cluster.
  • The log is multi-line, which does not interact well with some users' logging setups.
  • You can get the same info by running ray status.

Related issue number

#26670

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Dmitri Gekhtman added 2 commits January 23, 2023 12:23
Signed-off-by: Dmitri Gekhtman <dmitri.gekhtman@getcruise.com>
fix
Signed-off-by: Dmitri Gekhtman <dmitri.gekhtman@getcruise.com>
Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Dmitri Gekhtman <dmitri.gekhtman@getcruise.com>
@DmitriGekhtman
Copy link
Contributor Author

test_basic is known to be flakey

@DmitriGekhtman DmitriGekhtman merged commit 0cf060d into ray-project:master Jan 24, 2023
@DmitriGekhtman DmitriGekhtman changed the title [autoscaler] Add flag to disable periodic cluster status log. [autoscaler] Add env RAY_ENABLE_CLUSTER_STATUS_LOG to disable periodic cluster status log. Jan 25, 2023
@mbbyn
Copy link

mbbyn commented Jul 30, 2023

I believe RAY_ENABLE_CLUSTER_STATUS_LOG is completely missing from the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants