-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][state] Adjust worker side reporting with batches && add debugstring #31840
[core][state] Adjust worker side reporting with batches && add debugstring #31840
Conversation
…orker-side-batching
…orker-side-batching
Signed-off-by: rickyyx <rickyx@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about just sorting and popping? The current impl seems to have a couple tricky issues (read comments below) E.g.,
i = 0
while (i < next_index) {
// Append the first entry to the end until the next index
buffer_.append(buffer_.pop(0))
i += 1
}
next_index = 0
reported = 0
to_send = []
while (reported < batch_size) {
to_send.append(buffer_.pop(0))
}
|
Signed-off-by: rickyyx <rickyx@anyscale.com>
… TA-worker-side-batching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last question!
… TA-worker-side-batching
Awesome! Really happy with the final outcome! |
…tring (ray-project#31840) Signed-off-by: rickyyx <rickyx@anyscale.com> This PR introduces a flag RAY_task_events_send_batch_size that controls the number of task events sent to GCS in a batch. With default setting, each core worker will send 10K task events per second to GCS, where GCS could handle 10K task events in ~50 milliseconds. This PR also adjust the worker side buffer limit to 1M with the new batching setting. The PR adds some debug informations as well. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…d debugstring (ray-project#31840)" (ray-project#32024) This reverts commit 5d1f2e4. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…tring (remerging ray-project#31840) (ray-project#32057) Remerging ray-project#31840 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: rickyyx rickyx@anyscale.com
Why are these changes needed?
This PR introduces a flag
RAY_task_events_send_batch_size
that controls the number of task events sent to GCS in a batch. With default setting, each core worker will send 10K task events per second to GCS, where GCS could handle 10K task events in ~50 milliseconds.This PR also adjust the worker side buffer limit to 1M with the new batching setting.
The PR adds some debug informations as well.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.