Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] Add support for dynamic block splitting to actor pool. #31715

Merged
merged 3 commits into from
Jan 18, 2023
Merged

[Datasets] Add support for dynamic block splitting to actor pool. #31715

merged 3 commits into from
Jan 18, 2023

Conversation

clarkzinzow
Copy link
Contributor

This PR adds support for dynamic block splitting to the actor pool in the new execution backend.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 18, 2023
stephanie-wang
stephanie-wang approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@stephanie-wang stephanie-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

c21
c21 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clarkzinzow!

@clarkzinzow
Copy link
Contributor Author

clarkzinzow commented Jan 18, 2023 •
edited
Loading

Thanks for the reviews y'all! Newly added test isn't passing and I can't run it locally due to consistent SIGABRTs due to an actor manager deadlock, so I'll need to iterate via CI runs I decided to disable the stats actor locally to be able to iterate on the tests, and just pushed up a fix.

@clarkzinzow
Copy link
Contributor Author

All failing tests appear to be unrelated, merging.

@clarkzinzow clarkzinzow merged commit 87cbb62 into ray-project:master Jan 18, 2023
andreapiso pushed a commit to andreapiso/ray that referenced this pull request Jan 22, 2023
@clarkzinzow @andreapiso
[Datasets] Add support for dynamic block splitting to actor pool. (ra…
95c73d4 
…y-project#31715)

This PR adds support for dynamic block splitting to the actor pool in the new execution backend.

Signed-off-by: Andrea Pisoni <andreapiso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@stephanie-wang stephanie-wang stephanie-wang approved these changes

@c21 c21 c21 approved these changes

@scv119 scv119 Awaiting requested review from scv119

@jjyao jjyao Awaiting requested review from jjyao

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees

@ericl ericl

@stephanie-wang stephanie-wang

@c21 c21

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clarkzinzow @ericl @stephanie-wang @c21