Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Allow users to exclude config values with WandbLoggerCallback #31624

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

bveeramani
Copy link
Member

Signed-off-by: Balaji Veeramani balaji@anyscale.com

Why are these changes needed?

Our W&B integration species training configuration values that might not be relevant to the user (e.g., node_ip). This PR updates the exclude parameter to allow users to exclude these config values.

Note: you still can't exclude trial_log_path since it's hardcoded. See #28454.

Related issue number

Closes #31223

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani requested review from justinvyu and removed request for justinvyu January 12, 2023 02:10
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@krfricke krfricke merged commit 362796e into ray-project:master Jan 12, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
…31624)

Our W&B integration species training configuration values that might not be relevant to the user (e.g., `node_ip`). This PR updates the `exclude` parameter to allow users to exclude these config values.

_Note_: you still can't exclude `trial_log_path` since it's hardcoded. See #28454.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AIR] Provide option to exclude values from W&B config
3 participants