Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreWorker][deprecate run_function_on_all_workers 2/n] announcing deprecation of run_function_on_all_workers #31528

Merged
merged 2 commits into from
Jan 9, 2023
Merged

[CoreWorker][deprecate run_function_on_all_workers 2/n] announcing deprecation of run_function_on_all_workers #31528

merged 2 commits into from
Jan 9, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Jan 9, 2023 •
edited
Loading

Why are these changes needed?

Warn user that run_function_on_all_workers will be deleted by Ray 2.4. Ray core no longer uses this function after #31383

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review January 9, 2023 05:45
@scv119 scv119 changed the title [CoreWorker] announcing deprecation of run_function_on_all_workers [CoreWorker][deprecate run_function_on_all_workers 2/n] announcing deprecation of run_function_on_all_workers Jan 9, 2023
@scv119 scv119 mentioned this pull request Jan 9, 2023
Merged
7 tasks
@scv119 scv119 force-pushed the run-on-all-workers branch from f01efbb to 72fbc30 Compare January 9, 2023 18:25
cadedaniel
cadedaniel approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what This API will be deleted once we move the working dir init away. is referring to?

python/ray/_private/worker.py Outdated Show resolved Hide resolved
@scv119 @cadedaniel
Update python/ray/_private/worker.py
c66b645 
Co-authored-by: Cade Daniel <edacih@gmail.com>
Signed-off-by: Chen Shen <scv119@gmail.com>
@scv119
Copy link
Contributor Author

scv119 commented Jan 9, 2023 •
edited
Loading

Do you know what This API will be deleted once we move the working dir init away. is referring to?

yup, this is exactly what #31383 does

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 9, 2023
@scv119 scv119 merged commit c4f6a68 into ray-project:master Jan 9, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@scv119 @AmeerHajAli
[CoreWorker][deprecate run_function_on_all_workers 2/n] announcing de…
141d185 
…precation of run_function_on_all_workers (#31528)

Warn user that run_function_on_all_workers will be deleted by Ray 2.4. Ray core no longer uses this function after #31383
Signed-off-by: Chen Shen <scv119@gmail.com>
Co-authored-by: Cade Daniel <edacih@gmail.com>
scv119 added a commit that referenced this pull request Jun 8, 2023
@scv119
[Core][deprecate run_function_on_all_workers 3/n] delete run_function…
30e6b29 
…_on_all_workers (#30895)

This function is deprecated. The only use of run_funcion_on_all_workers in ray core has been replaced by #31383
Delete it to make our worker prestart change simpler.
This PR depends on #31383 #31528
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@scv119 @arvind-chandra
[Core][deprecate run_function_on_all_workers 3/n] delete run_function…
7b59e6e 
…_on_all_workers (ray-project#30895)

This function is deprecated. The only use of run_funcion_on_all_workers in ray core has been replaced by ray-project#31383
Delete it to make our worker prestart change simpler.
This PR depends on ray-project#31383 ray-project#31528

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadedaniel cadedaniel cadedaniel approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@cadedaniel cadedaniel

@rkooo567 rkooo567

@fishbone fishbone

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scv119 @cadedaniel @rkooo567 @fishbone