-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][state] Task state fault tolerance - GCS marks children task failed if parent task fails. [1/x] #31524
[core][state] Task state fault tolerance - GCS marks children task failed if parent task fails. [1/x] #31524
Conversation
@rkooo567 , could you do the main review? |
@rickyyx lmk when it is ready to review again (plz remove the label!) |
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to have another round of review (haven't reviewed child/parent update part and unit tests)!
Running release tests: https://buildkite.com/ray-project/release-tests-pr/builds/25388 Also see unresolved comments for follow-ups. |
Signed-off-by: rickyyx <rickyx@anyscale.com>
…-gcs-mark-failures
No regression from runs: https://buildkite.com/ray-project/release-tests-pr/builds/25408 , |
Signed-off-by: rickyyx rickyx@anyscale.com
Why are these changes needed?
We currently don't mark children tasks as failed if the parent fails. This PR adds a synchronous routine
MarkTaskTreeFailed
for each newly reported task event. And marks all children tasks in the task tree, with the reported task as the root, as failed, if:In the next PRs:
TaskState
for task exit details, e.g.exit_detail = Task failed because of parent task XXX failed at timestamp YYY
.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.