Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Issue 31174: Move all checks into AlgorithmConfig.validate() (even simple ones) to avoid errors when using tune hyperopt objects. #31396

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 3, 2023

Signed-off-by: sven1977 svenmika1977@gmail.com

Issue 31174: Move all checks into AlgorithmConfig.validate() (even simple ones) to avoid errors when using tune hyperopt objects.

Closes #31174

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Contributor

@maxpumperla maxpumperla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sven1977 sven1977 merged commit e0e75a8 into ray-project:master Jan 3, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
…(even simple ones) to avoid errors when using tune hyperopt objects. (#31396)
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
…(even simple ones) to avoid errors when using tune hyperopt objects. (ray-project#31396)

Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
@sven1977 sven1977 deleted the issue_31174_move_all_algo_config_checks_into_validate branch June 2, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants