[runtime_env] Fix failing wheel_urls release test
#31239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
Release test running here https://buildkite.com/ray-project/release-tests-pr/builds/24088 |
|
Forgot that this release test doesn't work on PRs, it's only designed to test wheels from master. It's currently failing on master so let's merge this fix. Windows tests unrelated (this PR just modifies a release test, release tests aren't run on Windows) |
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
This PR updates the release tests wheel_urls to make it compatible with the internal API change in PR #30970. Previously the release test was breaking with File "/home/ray/anaconda3/lib/python3.7/site-packages/ray/_private/utils.py", line 1266, in get_wheel_filename assert py_version in ray_constants.RUNTIME_ENV_CONDA_PY_VERSIONS, py_version AssertionError: 36
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
This PR updates the release tests wheel_urls to make it compatible with the internal API change in PR ray-project#30970. Previously the release test was breaking with File "/home/ray/anaconda3/lib/python3.7/site-packages/ray/_private/utils.py", line 1266, in get_wheel_filename assert py_version in ray_constants.RUNTIME_ENV_CONDA_PY_VERSIONS, py_version AssertionError: 36 Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Archit Kulkarni architkulkarni@users.noreply.github.com
Why are these changes needed?
This PR updates the release tests
wheel_urlsto make it compatible with the internal API change in PR #30970. Previously the release test was breaking withRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.