[Core] Fixed a potential buggy code where create_task is not invoked #31018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
simon-mo
approved these changes
Dec 12, 2022
architkulkarni
approved these changes
Dec 12, 2022
simon-mo
reviewed
Dec 12, 2022
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
|
@architkulkarni deleted that part. I don't remember what I was thinking to write lol |
|
also added an unit test for run_backgroun_task |
|
running a mac test now |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#31018) Signed-off-by: SangBin Cho <rkooo567@gmail.com> When using create_task in a "fire and forget" way, we should keep the references alive for the reliable execution. This API is used to fire and forget asynchronous execution. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
…31018) Signed-off-by: SangBin Cho <rkooo567@gmail.com> When using create_task in a "fire and forget" way, we should keep the references alive for the reliable execution. This API is used to fire and forget asynchronous execution.
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…ay-project#31018) Signed-off-by: SangBin Cho <rkooo567@gmail.com> When using create_task in a "fire and forget" way, we should keep the references alive for the reliable execution. This API is used to fire and forget asynchronous execution. Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SangBin Cho rkooo567@gmail.com
Why are these changes needed?
When using create_task in a "fire and forget" way, we should keep the references
alive for the reliable execution. This API is used to fire and forget
asynchronous execution.
Details:
This PR fixes the code that has the problem specified above ^. Also it implements a utility method to avoid such cases.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.