[tune/internal] Move signal handling into separate method #31004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
xwjiang2010
reviewed
Dec 10, 2022
python/ray/tune/tune.py
Outdated
| @@ -127,6 +127,39 @@ def _report_progress( | |||
| reporter.report(trials, done, sched_debug_str, executor_debug_str) | |||
|
|
|||
|
|
|||
| def _setup_signal_catching() -> threading.Event: | |||
| original_handler = signal.getsignal(signal.SIGINT) | |||
| stop_event = threading.Event() | |||
There was a problem hiding this comment.
more specific name? tune_loop_interrupted_event or something alike?
There was a problem hiding this comment.
If you're ok with it I'd like to keep this, as we set up general signal catching here and not just the event. Let me know if you disagree!
Meanwhile I'll kick of tune cloud release tests
There was a problem hiding this comment.
oh I mean the event name can be more specific? The method name _setup_signal_catching sounds fine to me!
There was a problem hiding this comment.
Ah I see! Yes, thanks, will updated!
added 2 commits
December 9, 2022 17:28
Signed-off-by: Kai Fricke <kai@anyscale.com>
Yard1
approved these changes
Dec 10, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…t#31004) This PR improves the tune.py code structure: - Signal handling is set up in a separate method - Signal handling now uses a threading event instead of a global dict - The GPU check is moved to before a trial runner is instantiated (and thus restored) in order to fail faster if fail conditions are met - Trial executor creation is moved closer to where the trial executor is passed Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
This PR improves the tune.py code structure: - Signal handling is set up in a separate method - Signal handling now uses a threading event instead of a global dict - The GPU check is moved to before a trial runner is instantiated (and thus restored) in order to fail faster if fail conditions are met - Trial executor creation is moved closer to where the trial executor is passed Signed-off-by: Kai Fricke <kai@anyscale.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…t#31004) This PR improves the tune.py code structure: - Signal handling is set up in a separate method - Signal handling now uses a threading event instead of a global dict - The GPU check is moved to before a trial runner is instantiated (and thus restored) in order to fail faster if fail conditions are met - Trial executor creation is moved closer to where the trial executor is passed Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
This PR improves the tune.py code structure:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.