[RLlib] Reduce SampleBatch counting complexity #30936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
| # has same length. | ||
| if isinstance(v, (Number, list)): | ||
| self[k] = np.array(v) | ||
|
|
There was a problem hiding this comment.
This was previously part of our counting code. Moving it does not yield a performance improvement but we should still move it.
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
7 tasks
gjoliver
approved these changes
Jan 18, 2023
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Andrea Pisoni <andreapiso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com
Why are these changes needed?
SampleBatch counting has a aspects that slow us down in connection with the QMix connectors regression.
Since we spend lots of time there instantiating new sample batches, we count alot.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.