[AIR] Place predictor kwargs in object store #30932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
amogkam
reviewed
Dec 6, 2022
clarkzinzow
requested changes
Dec 7, 2022
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
amogkam
approved these changes
Dec 7, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
If you pass predictor kwargs to BatchPredictor, they get pickled. As a result, if you pass a large object (for example, a large model definition), you get a value error. This PR fixes the issue by instead placing predictor kwargs in the object store. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
If you pass predictor kwargs to BatchPredictor, they get pickled. As a result, if you pass a large object (for example, a large model definition), you get a value error. This PR fixes the issue by instead placing predictor kwargs in the object store. Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Balaji Veeramani balaji@anyscale.com
Why are these changes needed?
If you pass predictor kwargs to
BatchPredictor, they get pickled. As a result, if you pass a large object (for example, a large model definition), you get a value error. This PR fixes the issue by instead placing predictor kwargs in the object store.Related issue number
Closes #30926
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.