[AIR] fixes bug passing 'raise' to FailureConfig #30814
Merged
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fail_fast must be one of {bool, 'raise'}. Got raise.`
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
6 tasks
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
amogkam
approved these changes
Dec 1, 2022
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
jeicher
pushed a commit
to tweag/ray
that referenced
this pull request
Dec 1, 2022
fixes bug where passing fail_fast='raise to FailureConfig raises ValueError: fail_fast must be one of {bool, 'raise'}. Got raise.
Closes ray-project#30813
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Dec 1, 2022
fixes bug where passing fail_fast='raise to FailureConfig raises ValueError: fail_fast must be one of {bool, 'raise'}. Got raise.
Closes ray-project#30813
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
7 tasks
xwjiang2010
added a commit
that referenced
this pull request
Dec 1, 2022
fixes bug where passing fail_fast='raise to FailureConfig raises ValueError: fail_fast must be one of {bool, 'raise'}. Got raise.
Closes #30813
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: Richard Decal <crypdick@users.noreply.github.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
fixes bug where passing fail_fast='raise to FailureConfig raises ValueError: fail_fast must be one of {bool, 'raise'}. Got raise.
Closes ray-project#30813
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
fixes bug where passing fail_fast='raise to FailureConfig raises ValueError: fail_fast must be one of {bool, 'raise'}. Got raise.
Closes ray-project#30813
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
fixes bug where passing
fail_fast='raisetoFailureConfigraisesValueError: fail_fast must be one of {bool, 'raise'}. Got raise.Closes #30813
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.