Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasets] Unrevert "Fix ndarray representation of single-element ragged tensor slices. (#30514)" #30721

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Nov 29, 2022

This unreverts #30514 by reverting commit 579770a.

A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.

Related Issues

Closes #30690

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarkzinzow
Copy link
Contributor Author

@jianoaix @c21 Ping for data team review, all tests look green!

@xwjiang2010 xwjiang2010 added the release-blocker P0 Issue that blocks the release label Nov 29, 2022
@clarkzinzow clarkzinzow merged commit 3df7825 into ray-project:master Nov 29, 2022
clarkzinzow added a commit to clarkzinzow/ray that referenced this pull request Nov 29, 2022
…ged tensor slices. (ray-project#30514)" (ray-project#30721)

This unreverts ray-project#30514 by reverting commit 579770a.

A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.
clarkzinzow added a commit that referenced this pull request Nov 30, 2022
…ged tensor slices. (#30514)" (#30721) (#30752)

This unreverts #30514 by reverting commit 579770a.

A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ged tensor slices. (ray-project#30514)" (ray-project#30721)

This unreverts ray-project#30514 by reverting commit 579770a.

A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
…ged tensor slices. (ray-project#30514)" (ray-project#30721)

This unreverts ray-project#30514 by reverting commit 579770a.

A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.

Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datasets] linux://python/ray/data:tests/test_transform_pyarrow is flaky
6 participants