-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datasets] Unrevert "Fix ndarray representation of single-element ragged tensor slices. (#30514)" #30721
Merged
clarkzinzow
merged 2 commits into
ray-project:master
from
clarkzinzow:datasets/unrevert/fix-ragged-slice-ndarray
Nov 29, 2022
Merged
[Datasets] Unrevert "Fix ndarray representation of single-element ragged tensor slices. (#30514)" #30721
clarkzinzow
merged 2 commits into
ray-project:master
from
clarkzinzow:datasets/unrevert/fix-ragged-slice-ndarray
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt ragged tensor slices. (ray-project#30514)" (ray-project#30709)" This reverts commit 579770a.
matthewdeng
approved these changes
Nov 29, 2022
c21
approved these changes
Nov 29, 2022
jianoaix
approved these changes
Nov 29, 2022
clarkzinzow
added a commit
to clarkzinzow/ray
that referenced
this pull request
Nov 29, 2022
…ged tensor slices. (ray-project#30514)" (ray-project#30721) This unreverts ray-project#30514 by reverting commit 579770a. A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.
clarkzinzow
added a commit
that referenced
this pull request
Nov 30, 2022
…ged tensor slices. (#30514)" (#30721) (#30752) This unreverts #30514 by reverting commit 579770a. A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ged tensor slices. (ray-project#30514)" (ray-project#30721) This unreverts ray-project#30514 by reverting commit 579770a. A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…ged tensor slices. (ray-project#30514)" (ray-project#30721) This unreverts ray-project#30514 by reverting commit 579770a. A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master. Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unreverts #30514 by reverting commit 579770a.
A test was merged into master while the original PR was open, which then broke when the original PR was merged. This wasn't caught in pre-merge checks since the PR was merged without having rebased onto latest master.
Related Issues
Closes #30690
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.