Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Rename DLPredictor.call_model tensor parameter to inputs #30574

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 22, 2022

Signed-off-by: Balaji balaji@anyscale.com

Why are these changes needed?

Some people get confused what the tensor argument represents. The name's ambiguous. This PR addressees the issue by renaming the parameter inputs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani marked this pull request as draft November 22, 2022 05:27
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we annotate call_model as a DeveloperAPI?

@bveeramani bveeramani marked this pull request as ready for review November 23, 2022 19:45
@amogkam amogkam merged commit f787413 into ray-project:master Nov 28, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ay-project#30574)

Some people get confused what the tensor argument represents. The name's ambiguous. This PR addressees the issue by renaming the parameter inputs.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
…ay-project#30574)

Some people get confused what the tensor argument represents. The name's ambiguous. This PR addressees the issue by renaming the parameter inputs.

Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants