[AIR] Raise error when batch_format is not specified for BatchMapper
#30366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault-batch-type Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
clarkzinzow
approved these changes
Nov 16, 2022
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
jiaodong
approved these changes
Nov 17, 2022
| @@ -26,7 +26,7 @@ def add_and_modify_udf(df: "pd.DataFrame"): | |||
| df["to_be_modified"] *= 2 | |||
| return df | |||
|
|
|||
| batch_mapper = BatchMapper(fn=add_and_modify_udf) | |||
| batch_mapper = BatchMapper(fn=add_and_modify_udf, batch_format="pandas") | |||
| @@ -132,7 +132,7 @@ def test_standard_scaler(): | |||
| @pytest.mark.parametrize( | |||
| "preprocessor", | |||
| [ | |||
| BatchMapper(fn=lambda x: x), | |||
| BatchMapper(fn=lambda x: x, batch_format="pandas"), | |||
|
Hmm @jiaodong, the string API is the user facing API right? For consistency with And so our tests should use the same user facing API? |
This was referenced Nov 17, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…er` (ray-project#30366) In Ray 2.1, we deprecated the default batch_format argument for BatchMapper and made it required. In Ray 2.2, we upgrae the warning from logging a warning to raising an error. Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: amogkam amogkamsetty@yahoo.com
In Ray 2.1, we deprecated the default batch_format argument for
BatchMapperand made it required. In Ray 2.2, we upgrae the warning from logging a warning to raising an error.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.