Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix doc test for foreach_worker_with_index #30252

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com

Screenshot 2022-11-14 at 09 03 56

WorkerSet no long has foreach_worker_with_index

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
@maxpumperla
Copy link
Contributor

@ArturNiederfahrenhorst cool, thanks for fixing this! btw, we have a lot of other dead code like this on our docs. this was just a fairly mindless copy (from rst to py) of what has been up for maybe years. We should really get after that soonish, for the sake of managing retention.

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
@gjoliver gjoliver merged commit c4b9b19 into ray-project:master Nov 15, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the fixdoctest branch January 5, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants