[Tune] Sync experiment-checkpoints more often #30187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
krfricke
requested changes
Nov 10, 2022
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
|
Other than fixing the CI failures, please also run the |
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
|
@krfricke Release tests are green, test failures are same as on master. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
In order to improve checkpoint consistency, experiment syncing is now forced if a trial has checkpointed more than `num_to_keep` times since last sync. If `num_to_keep` is not set, nothing is changed. Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This was referenced Jan 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In order to improve checkpoint consistency, experiment syncing is now forced if a trial has checkpointed more than
num_to_keeptimes since last sync. Ifnum_to_keepis not set, nothing is changed.Related issue number
Closes #30073
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.