Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] minor bug fix. Resetted exceptions are saved under env_id key. #30183

Merged
merged 2 commits into from
Nov 10, 2022
Merged

[RLlib] minor bug fix. Resetted exceptions are saved under env_id key. #30183

merged 2 commits into from
Nov 10, 2022

Conversation

gjoliver
Copy link
Member

Signed-off-by: Jun Gong jungong@anyscale.com

Why are these changes needed?

This is the exact same logic _env_runner() uses.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [*] Unit tests
    • Release tests
    • This PR is not tested :(

[RLlib] minor bug fix. Resetted exceptions are saved under env_id key.
4ad48f2 
Signed-off-by: Jun Gong <jungong@anyscale.com>
lint
45e54a6 
Signed-off-by: Jun Gong <jungong@anyscale.com>
ArturNiederfahrenhorst
ArturNiederfahrenhorst approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gjoliver gjoliver added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Nov 10, 2022
@gjoliver gjoliver merged commit 20d1a70 into ray-project:master Nov 10, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@WeichenXu123
[RLlib] minor bug fix. Resetted exceptions are saved under env_id key. (
922a1af 
ray-project#30183)

Signed-off-by: Jun Gong <jungong@anyscale.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturNiederfahrenhorst ArturNiederfahrenhorst ArturNiederfahrenhorst approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@avnishn avnishn Awaiting requested review from avnishn

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@ArturNiederfahrenhorst ArturNiederfahrenhorst

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjoliver @ArturNiederfahrenhorst