Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] AlgorithmConfig: Replace more occurrences of old config dicts; Make all Algorithms use the non-dict lookup for config properties. #30096

Merged
merged 14 commits into from
Nov 10, 2022
Merged

[RLlib] AlgorithmConfig: Replace more occurrences of old config dicts; Make all Algorithms use the non-dict lookup for config properties. #30096

merged 14 commits into from
Nov 10, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 8, 2022 •
edited
Loading

Signed-off-by: sven1977 svenmika1977@gmail.com

This PR changes:

  • AlgorithmConfig: Replace more occurrences of old config dicts in tests, examples, and docs.
  • Make all Algorithms use the non-dict lookup for config properties.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
78d294d 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
ff352f2 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
maxpumperla
maxpumperla approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@maxpumperla maxpumperla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe tackle the docs stuff (there's more) later

doc/source/rllib/rllib-algorithms.rst Outdated
@@ -932,8 +931,8 @@ as the module uses the values from the paper by default. For example:
# exploration, e.g. EpsilonGreedy for DQN, StochasticSampling for PG/SAC).
"sub_exploration": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this overlaps with my efforts in #29796. Don't want to create merge conflicts here!

sven1977 added 10 commits November 8, 2022 17:32
@sven1977
fixes
c062ca3 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
fixes
dd8051c 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
fec151b 
…_configs_next_steps_6
@sven1977
fix
0e4d049 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
1684739 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
4ede3f8 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
418d4c0 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
2af51ed 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
59cb702 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
merge
1e9bf2f 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Nov 9, 2022
@sven1977
merge
3cd0b53 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
dbfaa30 
…_configs_next_steps_6
@sven1977 sven1977 merged commit e715a8b into ray-project:master Nov 10, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@sven1977 @WeichenXu123
[RLlib] AlgorithmConfig: Replace more occurrences of old config dicts…
29a3ee1 
…; Make all Algorithms use the non-dict lookup for config properties. (ray-project#30096)

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@sven1977 sven1977 deleted the algo_configs_next_steps_6 branch June 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpumperla maxpumperla maxpumperla approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@maxpumperla maxpumperla

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @maxpumperla