-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Deprecate get_algorithm_class()
.
#30053
[RLlib] Deprecate get_algorithm_class()
.
#30053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though tests are failing due to some recursion issue.
I've added a commit that resolves the circular calls |
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
.. and these fixes are simple ones for the few failing tests. |
…ecate_get_algorithm_class
…en1977/ray into deprecate_get_algorithm_class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: sven1977 svenmika1977@gmail.com
Deprecate
get_algorithm_class()
.In favor of
ray.tune.registry.get_trainable_cls()
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.