Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune] Fix Jupyter output with Ray Client and Tuner #29956

Merged
merged 11 commits into from
Nov 10, 2022
Merged

[Tune] Fix Jupyter output with Ray Client and Tuner #29956

merged 11 commits into from
Nov 10, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Nov 2, 2022 •
edited
Loading

Why are these changes needed?

Ensures that we can have rich Jupyter output with the Tuner API.

Related issue number

Closes #29863

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Yard1 added 2 commits November 2, 2022 19:19
@Yard1
WIP
9128578 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
WIP
f65a5df 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 requested review from krfricke and xwjiang2010 November 2, 2022 20:24
@Yard1 Yard1 changed the title Fix tuner jupyter output with client [Tune] Fix Jupyter output with Ray Client and Tuner Nov 2, 2022
Yard1 added 4 commits November 2, 2022 20:42
@Yard1
Increase timeout
b90f41b 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Lint
0463baa 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Add test
63a5625 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Increase size
50eba7a 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
krfricke
krfricke reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but let's clean up some legacy clutter while we're at it

python/ray/tune/tuner.py Outdated Show resolved Hide resolved
python/ray/tune/progress_reporter.py Outdated Show resolved Hide resolved
@Yard1
Apply feedback from code review
f52d58e 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 requested a review from krfricke November 4, 2022 19:07
krfricke
krfricke reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor questions

python/ray/tune/impl/tuner_internal.py Outdated Show resolved Hide resolved
Yard1 added 2 commits November 8, 2022 18:45
@Yard1
Pop from state dict
aaaaf5f 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'ray-project:master' into fix_tuner_jupyter_output_with_…
af07494 
…client
@Yard1 Yard1 requested a review from krfricke November 8, 2022 18:46
krfricke
krfricke approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@krfricke krfricke merged commit 993008e into ray-project:master Nov 10, 2022
@Yard1 Yard1 deleted the fix_tuner_jupyter_output_with_client branch November 10, 2022 17:35
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@Yard1 @WeichenXu123
[Tune] Fix Jupyter output with Ray Client and Tuner (ray-project#29956
fd6b4e3 
)

Ensures that we can have rich Jupyter output with the Tuner API.

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

Assignees

@krfricke krfricke

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tune] Tuner doesn't support Jupyter rich output
3 participants
@Yard1 @krfricke @xwjiang2010