Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Avoid checkpoint conversion (horovod fixed) #29785

Merged

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Oct 27, 2022

Why are these changes needed?

#28794 fixed to avoid the issue discovered in #29784 (comment)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Yard1 added 2 commits October 27, 2022 23:16
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 requested review from matthewdeng and amogkam October 27, 2022 23:20
@Yard1 Yard1 changed the title [AIR] Train avoid checkpoint conversion fixed [AIR] Avoid checkpoint conversion (horovod fixed) Oct 27, 2022
Yard1 added 2 commits October 28, 2022 16:34
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@amogkam amogkam merged commit c4c6ffe into ray-project:master Oct 28, 2022
@Yard1 Yard1 deleted the train_avoid_checkpoint_conversion_fixed branch October 28, 2022 18:53
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
ray-project#28794 fixed to avoid the issue discovered in ray-project#29784 (comment)

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
amogkam pushed a commit that referenced this pull request Mar 28, 2023
…ata (#33784)

These methods were soft deprecated in (Ray 2.2): #29785.

This PR hard deprecates these. In the future, we will completely remove these APIs along with the corresponding encode_data and decode_data methods as well as their usages (e.g. encode_data_fn).

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…ata (ray-project#33784)

These methods were soft deprecated in (Ray 2.2): ray-project#29785.

This PR hard deprecates these. In the future, we will completely remove these APIs along with the corresponding encode_data and decode_data methods as well as their usages (e.g. encode_data_fn).

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…ata (ray-project#33784)

These methods were soft deprecated in (Ray 2.2): ray-project#29785.

This PR hard deprecates these. In the future, we will completely remove these APIs along with the corresponding encode_data and decode_data methods as well as their usages (e.g. encode_data_fn).

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants