Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Deprecate AlgorithmConfig.framework("tfe"): Use tf2 instead. #29755

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 27, 2022

Signed-off-by: sven1977 svenmika1977@gmail.com

Deprecate AlgorithmConfig.framework("tfe"): Use tf2 instead.

tfe and tf2 have the same meaning. There used to be a difference in the tf main-version (1.x vs 2.x) for these two settings, but that difference has already been equalized in RLlib's code.
We are now throwing an error, hinting to use "tf2", if a user tries to set framework="tfe".

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit 432f023 into ray-project:master Oct 27, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ad. (ray-project#29755)

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@sven1977 sven1977 deleted the deprecate_framework_tfe branch June 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants