[Tune] Keep resource specifications when nesting with_resources
in with_parameters
#29740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Order of nesting matters
The order of nesting matters when using
tune.with_parameters
andtune.with_resources
together. Whentune.with_resources
is nested inside atune.with_parameters
, the resource specification is dropped and not considered when launching the trials.This PR introduces a fix for both cases above to work.
tune.with_parameters
on a training function with a return valueAnother issue addressed in this PR (let me know if this should be its own PR) is allowing
tune.with_parameters
to work with custom training functions that return a value.This PR returns the original training function's return value instead of dropping it.
Open questions
_resource
attribute. Is there a better way to keep the resource specification information around?Related issue number
Closes #29235
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.