Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Remove tensorflow_autoencoder_example #29589

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Oct 23, 2022

Signed-off-by: Balaji balaji@anyscale.com

Why are these changes needed?

tensorflow_autoencoder_example isn't used anywhere. It's out of date, and it hasn't been tested for more than three months.

Since we don't have any plans to fix it, we should remove it. Unused files are bad.

Related issue number

See #25070 and #26409

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani assigned richardliaw and amogkam and unassigned richardliaw Oct 23, 2022
@bveeramani bveeramani mentioned this pull request Oct 23, 2022
8 tasks
@richardliaw richardliaw removed their assignment Oct 27, 2022
@amogkam
Copy link
Contributor

amogkam commented Oct 27, 2022

@bveeramani can you merge in master

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@richardliaw richardliaw merged commit 41a3aa3 into ray-project:master Oct 31, 2022
scottjlee pushed a commit to scottjlee/ray that referenced this pull request Nov 1, 2022
Signed-off-by: Scott Lee <sjl@anyscale.com>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants