Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasets] Fuse AllToAllStage and OneToOneStage with compatible remote args #29561

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Oct 21, 2022

Signed-off-by: Jiajun Yao jeromeyjj@gmail.com

Why are these changes needed?

Currently random_shuffle_map cannot be fused with pervious OneToOneStage even though they have compatible remote args.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@jjyao jjyao merged commit 8668511 into ray-project:master Oct 22, 2022
@jjyao jjyao deleted the jjyao/fuse branch October 22, 2022 00:22
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…-project#29561)

Currently random_shuffle_map cannot be fused with pervious OneToOneStage even though they have compatible remote args.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants