Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] Fix TensorflowTrainer docstring example #29463

Merged
merged 9 commits into from
Dec 9, 2022
Merged

[AIR] Fix TensorflowTrainer docstring example #29463

merged 9 commits into from
Dec 9, 2022

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Oct 19, 2022 •
edited
Loading

Signed-off-by: Balaji balaji@anyscale.com

Why are these changes needed?

You can't run the code, because we don't provide an argument to train_loop_per_worker.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam
Copy link
Contributor

amogkam commented Oct 19, 2022 •
edited
Loading

Can we rewrite this to have it run in CI? I think we have had some changes recently to make this possible. You can take a look at TensorflowCheckpoint.from_* method docstrings for an example

@amogkam amogkam added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 1, 2022
@stale
Copy link

stale bot commented Dec 3, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 3, 2022
@bveeramani
Merge remote-tracking branch 'upstream/master'
63432eb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
2c33947 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'master' into tf-trainer-example
7038deb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update tensorflow_trainer.py
5303fe1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
amogkam
amogkam approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this!

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 7, 2022
@bveeramani
Update tensorflow_trainer.py
58f0188 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@amogkam amogkam merged commit b027566 into ray-project:master Dec 9, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@bveeramani @WeichenXu123
[AIR] Fix TensorflowTrainer docstring example (ray-project#29463)
9d6b764 
You can't run the code, because we don't provide an argument to train_loop_per_worker.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@bveeramani @tamohannes
[AIR] Fix TensorflowTrainer docstring example (ray-project#29463)
2bdb2f8 
You can't run the code, because we don't provide an argument to train_loop_per_worker.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees

@matthewdeng matthewdeng

@amogkam amogkam

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bveeramani @amogkam @matthewdeng