Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve map_batches() documentation about execution model and UDF pic… #29233

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Oct 11, 2022

…kle-ability requirement

Signed-off-by: jianoaix iamjianxiao@gmail.com

Why are these changes needed?

Without documentation about execution model and UDF pickle requirement, users got confused.

Related issue number

#28651

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…kle-ability requirement

Signed-off-by: jianoaix <iamjianxiao@gmail.com>
Signed-off-by: jianoaix <iamjianxiao@gmail.com>
@jianoaix
Copy link
Contributor Author

Ping for review or merge?

@jianoaix
Copy link
Contributor Author

Genle ping again?

@ericl ericl merged commit 2bb96b7 into ray-project:master Oct 18, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
ray-project#29233)

Without documentation about execution model and UDF pickle requirement, users got confused.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants