-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Get rid of experimental_relax_shapes #29214
[RLlib] Get rid of experimental_relax_shapes #29214
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
@ArturNiederfahrenhorst is this still relevant? |
@krfricke Yes this is still relevant, reopening |
Anyway: experimental_relax_shapes is being deprecated: https://www.tensorflow.org/api_docs/python/tf/function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamp! Thanks for the upgrade @ArturNiederfahrenhorst .
…apes` (but `reduce_retracing` instead). (ray-project#29214) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
…apes` (but `reduce_retracing` instead). (ray-project#29214) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com
Why are these changes needed?
Our logs:
![Screenshot 2022-10-11 at 16 36 53](https://user-images.githubusercontent.com/9356806/195121084-da690982-fbd5-47e6-9e5c-fcd38fa0f2d4.png)
From the docs of tf.function:
![Screenshot 2022-10-11 at 16 37 12](https://user-images.githubusercontent.com/9356806/195121162-acf2c4a6-7629-4315-b7c0-d38077795573.png)
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.