Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Get rid of experimental_relax_shapes #29214

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com

Why are these changes needed?

Our logs:
Screenshot 2022-10-11 at 16 36 53

From the docs of tf.function:
Screenshot 2022-10-11 at 16 37 12

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
@stale
Copy link

stale bot commented Nov 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Nov 12, 2022
@stale
Copy link

stale bot commented Nov 26, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Nov 26, 2022
@krfricke
Copy link
Contributor

@ArturNiederfahrenhorst is this still relevant?

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Nov 30, 2022
@ArturNiederfahrenhorst
Copy link
Contributor Author

@krfricke Yes this is still relevant, reopening

@ArturNiederfahrenhorst
Copy link
Contributor Author

ArturNiederfahrenhorst commented Dec 29, 2022

Anyway: experimental_relax_shapes is being deprecated: https://www.tensorflow.org/api_docs/python/tf/function

@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLlib] Get rid of some TF deprecation warnings [RLlib] Get rid of experimental_relax_shapes Jan 29, 2023
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp! Thanks for the upgrade @ArturNiederfahrenhorst .

@sven1977 sven1977 merged commit 78b8c24 into ray-project:master Jan 31, 2023
clarng pushed a commit to clarng/ray that referenced this pull request Jan 31, 2023
…apes` (but `reduce_retracing` instead). (ray-project#29214)

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…apes` (but `reduce_retracing` instead). (ray-project#29214)

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants