[air] Fix Tune checkpoint tracking for minimizing metrics #29145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2022 16:38
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
7 tasks
|
Brilliant! I ran into this bug today. I can provide a reproducible case if you want. |
amogkam
reviewed
Oct 7, 2022
Yard1
reviewed
Oct 7, 2022
Yard1
added a commit
to Yard1/ray
that referenced
this pull request
Oct 7, 2022
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
xwjiang2010
approved these changes
Oct 7, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…t#29145) We're currently passing the checkpoint score attribute to the tune checkpoint manager without adding the legacy prefix `min-` if we want to minimize the metric. This leads to faulty tracking of checkpoints. In this PR, we update Tune's checkpoint manager to accept the full checkpoint config directly, avoiding problems in converting between the legacy format and the new API. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
We're currently passing the checkpoint score attribute to the tune checkpoint manager without adding the legacy prefix
min-if we want to minimize the metric. This leads to faulty tracking of checkpoints. In this PR, we update Tune's checkpoint manager to accept the full checkpoint config directly, avoiding problems in converting between the legacy format and the new API.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.