[air] Fix traceback context swallowing in training jobs #29143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
Yard1
approved these changes
Oct 6, 2022
# Conflicts: # python/ray/tune/trainable/trainable.py
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…29143) We currently raise `skip_exceptions(e) from None` to reduce the stacktrace output of failing functions. However, in python this means that the context is swallowed completely, even if `skip_exceptions(e)` returns an exception with context. the `from None` takes precedence. The solution here is to extract the cause manually from the new `skip_exceptions(e)`-Exception and raise from this context. The tests are still passing (thus for regular cases the traceback remains compact), but the repro script in ray-project#29097 will reveal the actual cause of the error. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
We currently raise
skip_exceptions(e) from Noneto reduce the stacktrace output of failing functions. However, in python this means that the context is swallowed completely, even ifskip_exceptions(e)returns an exception with context. thefrom Nonetakes precedence.The solution here is to extract the cause manually from the new
skip_exceptions(e)-Exception and raise from this context. The tests are still passing (thus for regular cases the traceback remains compact), but the repro script in #29097 will reveal the actual cause of the error.Related issue number
Closes #29097
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.