Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Quick fix for MultiAgentEnv.observation_space_contains #29077

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

gjoliver
Copy link
Member

@gjoliver gjoliver commented Oct 5, 2022

Signed-off-by: Jun Gong jungong@anyscale.com

Why are these changes needed?

Dict gym space doesn't work like dict. We shouldn't use in to check membership.

Related issue number

Closes #28667

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [*] Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jun Gong <jungong@anyscale.com>
@gjoliver gjoliver merged commit a5c50fe into ray-project:master Oct 5, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…roject#29077)

Signed-off-by: Jun Gong <jungong@anyscale.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLlib] Bug in observation_space_contains
2 participants