Keep objects in cache between tasks #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior so that if we get an object and let the object go out of scope, it will not unmap the object's memory immediately, only after a delay (i.e. after more objects went out of scope).
This is an important optimization, because unmap flushes the cpu cache. If tasks reuse the same objects, the objects sho ld stay in the cpu cache between task boundaries. This optimization is especially important for iterative workloads.
This illustrates the performance difference (it is ~2x slower without this PR).