[RLlib] Make sure ViewRequirementAgentConnector's agent collector does not keep full history. #28938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not keep full history. Signed-off-by: Jun Gong <jungong@anyscale.com>
| # Feed ViewRequirementAgentConnector 5 samples. | ||
| c([data]) | ||
|
|
||
| obs_data = c.agent_collectors[0][1].buffers["obs"][0] |
There was a problem hiding this comment.
Makes sense. Curious, what was the behavior of obs_data before you make this is_training=False?
There was a problem hiding this comment.
goes up to however long the episode is.
and then during each timestep, we convert the whole episode into numpy ...
kouroshHakha
approved these changes
Sep 30, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…s not keep full history. (ray-project#28938) Signed-off-by: Jun Gong <jungong@anyscale.com> Signed-off-by: Jun Gong <jungong@anyscale.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Gong jungong@anyscale.com
Why are these changes needed?
Things are super slow otherwise.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.