Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Support tune.with_resources for class methods #28596

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

krfricke
Copy link
Contributor

Signed-off-by: Kai Fricke kai@anyscale.com

Why are these changes needed?

tune.with_resources sets an attribute, but this is not supported in class methods. This PR wraps around class methods to add support.

Related issue number

Closes #28514

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke merged commit 406c288 into ray-project:master Sep 19, 2022
@krfricke krfricke deleted the tune/with-resources-method branch September 19, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[air/tune] AttributeError: 'method' object has no attribute '_resources'
2 participants