Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Add DTTorchModel #27872

Merged
merged 13 commits into from
Aug 17, 2022
Merged

[RLlib] Add DTTorchModel #27872

merged 13 commits into from
Aug 17, 2022

Conversation

charlesjsun
Copy link
Contributor

Why are these changes needed?

Part of adding DT to RLlib.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@charlesjsun
Added segmentation buffer
d6d446c 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun charlesjsun requested a review from sven1977 as a code owner August 15, 2022 16:59
avnishn
avnishn reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had some minor nits otherwise lgtm

rllib/algorithms/dt/tests/test_dt_model.py Show resolved Hide resolved
rllib/algorithms/dt/tests/test_dt_model.py Outdated Show resolved Hide resolved
@charlesjsun
address some pr reviews
4339108 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
add padding test and fix sample
743ea9e 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
samplebatch split using dones
21a2e8b 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
add change warning to error and test
1f32321 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
comment
d06ee45 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
Merge branch 'master' of github.com:ray-project/ray into dt_segmentat…
35f9ea1 
…ion_buffer
@kouroshHakha
Copy link
Contributor

Loved this PR. Very clean and clear. the only thing remaining is adding a unittest that checks for causality within the model.

@charlesjsun
added stuff
bddf887 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
torch model
ba9d46f 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
address PR reviews
3e4cda6 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
add attention output and causal test
358ef40 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@charlesjsun
fix test imports
99a89c3 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
kouroshHakha
kouroshHakha approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardliaw LGTM. Please merge after the Segmentation buffer PR is merged.

@charlesjsun
fix merge conflict
7cdf71f 
Signed-off-by: Charles Sun <charlesjsun@gmail.com>
@richardliaw richardliaw merged commit 6188059 into ray-project:master Aug 17, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@charlesjsun
[RLlib] Add DTTorchModel (ray-project#27872)
2b53a56 
Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnishn avnishn avnishn left review comments

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@gjoliver gjoliver Awaiting requested review from gjoliver

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@sven1977 sven1977

@kouroshHakha kouroshHakha

@avnishn avnishn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@charlesjsun @kouroshHakha @avnishn @richardliaw @sven1977