[doc] Convert custom datetime column when reading a CSV file #27854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
e7834a1 to
1eec504
Compare
matthewdeng
reviewed
Aug 15, 2022
python/ray/data/read_api.py
Outdated
Comment on lines
565
to
570
| >>> # Convert a date column with a custom format from a CSV file. | ||
| >>> from pyarrow import csv | ||
| >>> convert_options = csv.ConvertOptions( | ||
| ... timestamp_parsers=["%m/%d/%Y"]) |
There was a problem hiding this comment.
Would it make sense to generalize this example to all convert_options (pyarrow.csv.ConvertOptions) or even arrow_csv_args?
In other words, should we delegate this documentation over to Arrow?
There was a problem hiding this comment.
Yes, part of my desire to document this is to make sure that people know how to put in arbitrary ConvertOptions (and I wanted to show one that is probably particularly useful as an example). I'll add a note about the more general case and also link the Arrow documentation :)
9a8934a to
4783086
Compare
4783086 to
9a8934a
Compare
|
Haha yeah, I fixed it now :) |
XiaodongLv
pushed a commit
to XiaodongLv/ray
that referenced
this pull request
Sep 2, 2022
…ject#27854) Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
ilee300a
pushed a commit
to ilee300a/ray
that referenced
this pull request
Sep 12, 2022
…ject#27854) Signed-off-by: Philipp Moritz <pcmoritz@gmail.com> Signed-off-by: ilee300a <ilee300@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Give an example of how a datetime column can be parsed when reading a CSV file.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.