[RLlib] Fix SAC config parameter that is not used #27741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
approved these changes
Aug 11, 2022
|
Hey @ArturNiederfahrenhorst , could you double-check the test 2 case failures? Seems connector related, but these tests are currently passing in master, so just making 100% sure. Thanks |
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com
Why are these changes needed?
SAC's config has a paramter "optimization_config" that will not be used during execution because "optimization" is accessed. We have this discrepancy between argument name during configuration time and parameter name that is later accessed in other places. This has to be kept for now to stay backward compatible.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.